Profiling documentation #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spillai
reviewed
Jan 31, 2024
| ```bash | ||
| pip install torch-nos[server,test] | ||
| ``` | ||
|
|
There was a problem hiding this comment.
It might be helpful to break this README by subcommand:
First, can you print the output of nos profile --help here so that the users can see the relevant subcommands supported?
Then you can have different sections such as
nos profile rebuild-catalog
...
nos profile method -m <model-id>
nos profile method -t <model-type>
spillai
reviewed
Jan 31, 2024
|
|
||
| Or an entire method type with | ||
| ```bash | ||
| nos profile method -m encode_image |
There was a problem hiding this comment.
Are method type and method names interchangeable here with -m flag? Wouldn't we want them to have a different flag? -m for model name and -t for method type?
spillai
reviewed
Jan 31, 2024
nos/common/spec.py
Outdated
| logger = logging.getLogger(__name__) | ||
| debug_str = "Loading profiling catalog from " + str(NOS_PROFILE_CATALOG_PATH) | ||
| # Check if we have NOS_PROFILE_CATALOG_PATH_OVERRIDE in the environment | ||
| if "NOS_PROFILE_CATALOG_PATH_OVERRIDE" in os.environ: |
There was a problem hiding this comment.
Use os.environ.get("...", None) instead?
outtanames
force-pushed
the
sloftin/load-catalog-from-env
branch
from
1c13c74
to
c1c7c28
Compare
outtanames
force-pushed
the
sloftin/load-catalog-from-env
branch
from
c1c7c28
to
e6ad878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short doc describing
nos profile. Also includes funcionality to override catalog path from env withNOS_PROFILE_CATALOG_PATH_OVERRIDE(for use withnos profile list).Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.